Refactor Hubble Stats code #1481
Conversation
|
✅ Deploy Preview for webb hubble statistic is ready! Thanks for the contribution @vutuanlinh2k2
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
I noticed that you've refactored some components in the hubble-stats dapp to be client components. While your effort is much appreciated, I'm not entirely convinced about the benefits of these changes. Could you kindly take another look at these components? Just as a reminder, client components are those that manage the client's state or side effects. Thanks in advance for your consideration!
apps/hubble-stats/containers/KeyMetricsTableContainer/KeyMetricsTableContainer.tsx
Outdated
Show resolved
Hide resolved
apps/hubble-stats/containers/PoolOverviewContainer/PoolOverviewContainer.tsx
Outdated
Show resolved
Hide resolved
| 'use client'; | ||
|
|
There was a problem hiding this comment.
This is okay, but I propose we create a task to review our components in the webb-ui-kit. The aim would be to determine which components are client-related, and which are associated with the server. Could you kindly create an issue to address this?
AtelyPham
added
needs changes 🔧
|
✅ Deploy Preview for webb hubble statistic is ready! Thanks for the contribution @vutuanlinh2k2
To edit notification comments on pull requests, go to your Netlify site settings. |
vutuanlinh2k2
added
needs review 👓
Summary of changes
Provide a detailed description of proposed changes.
Proposed area of change
Put an
xin the boxes that apply.apps/bridge-dappapps/hubble-statsapps/stats-dappapps/webbsiteapps/faucetapps/tangle-websitelibs/webb-ui-componentsReference issue to close (if applicable)
Specify any issues that can be closed from these changes (e.g. Closes #233).
Code Checklist
Please be sure to add .stories documentation if any additions are made to
libs/webb-ui-components.